Catch error from p7zip 9.20 when deleting files from apk-archives
ClosedPublic
Actions

Authored by rthomsen on Mar 10 2017, 9:34 PM.

Details

Reviewers

Commits

R36:f8df291a061f: cli7z: Catch error from p7zip 9.20 when deleting files from APK archives

Summary

A new member function was added to CliInterface named readDeleteLine(). The function is overridden in cli7z plugin and the error message is handled.

Bug 377421.

Test Plan

Downgrade p7zip to 9.20 and try deleting a file from an apk archive. An error message should be shown.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rthomsen created this revision.Mar 10 2017, 9:34 PM

Restricted Application added a project: Ark. · View Herald TranscriptMar 10 2017, 9:34 PM

Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript

rthomsen retitled this revision from Catch error from p7zip when deleting files from apk-archives to Catch error from p7zip 9.20 when deleting files from apk-archives.Mar 10 2017, 9:39 PM

rthomsen edited the summary of this revision. (Show Details)

rthomsen edited the test plan for this revision. (Show Details)

rthomsen added a reviewer: elvisangelaccio.

rthomsen edited the summary of this revision. (Show Details)

elvisangelaccio accepted this revision.Mar 10 2017, 10:16 PM

This revision is now accepted and ready to land.Mar 10 2017, 10:16 PM

Closed by commit R36:f8df291a061f: cli7z: Catch error from p7zip 9.20 when deleting files from APK archives (authored by rthomsen). · Explain WhyMar 13 2017, 6:32 PM

This revision was automatically updated to reflect the committed changes.

rthomsen mentioned this in R36:f8df291a061f: cli7z: Catch error from p7zip 9.20 when deleting files from APK archives.

Revision Contents
Changeset List

			Path	Packages
M			kerfuffle/cliinterface.h (1 line)
M			kerfuffle/cliinterface.cpp (10 lines)
M			plugins/cli7zplugin/cliplugin.h (1 line)
M			plugins/cli7zplugin/cliplugin.cpp (12 lines)