add --format switch for setting output color and use regex to match format pattern for sanity check before trigger sprintf.
e.g. kdialog --getcolor --format "%+3.7f %.4f %5f" in "%[flag][width][precision][length]<conversion specifier>"
BUG: 340399
Details
Details
- Reviewers
cfeck - Commits
- R229:c78683dde164: Allow setting output format for --getcolor
kdialog --getcolor --format "Qcolor(%#x, %+2.2lx, %#+3.3lx)"
Qcolor(0x6d, +60, +0x07b)
Diff Detail
Diff Detail
- Repository
- R229 KDialog
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Hi, @cfeck please take a look, thanks
This patch is updated almost according https://bugs.kde.org/show_bug.cgi?id=340399 except the following two.
- When adding %1$ %2$ to enable reorder RGB channel, I was told "ISO C++11 does not support %n$ operand number formats [-Wformat=]";
- For "L" specifier expects long double while in QColor only has qreal and if we call asprinf("%Lg", redF()), we'll get an Nan outcome. Since qreal of QColor is double on all platform except float on ARM, this patch does skip this length specifier.