As discussed on cfe-dev, this can prevent template instantiations from being created.
I also notice that I get fewer spurious diagnostics with this fix.
It seems reasonable to not use Incomplete when parsing a proper TU url.
Details
Details
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
LGTM, but can you show me the discussion?
Maybe even add a link to the discussion to the source code.
Comment Actions
Tentative +1, but what happens without the Incomplete flag when we have a parse error due to the background parser kicking in while we are typing? Do we still get a (partial) AST then, or will it break early like the real compiler?
Comment Actions
According to the documentation, this just means that "semantic analysis that is typically performed at the end of the translation unit will be suppressed"
I don't notice any instances of the compiler bailing on error either -- we still get a complete AST afaict.
Comment Actions
ok, please add a link to the discussion as requested by kevin, then +1 from my side.
unit tests all continue to pass, I guess.