Grepped code for repaintNeeded on prefixes and adjusted as appropriately to match
D4827
Details
Details
- Reviewers
broulik - Group Reviewers
Plasma - Commits
- R119:a521ac8f8882: Adjust plasma-desktop to the new fallback prefixes
Booted, looks the same.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
| applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml | ||
|---|---|---|
| 46 | You don't take into account orientation here (south/north/west/...) which TaskTools.taskPrefix does | |
| applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml | ||
|---|---|---|
| 46 ↗ | (On Diff #11958) | Now you place an array inside of an array. (btw knotifications has a unitylauncher test app where you can test this, e.g. ~/Projects/kf5-build/knotifications/tests/unitylaunchertest org.kde.dolphin --progress 50) |
Comment Actions
When I move my panel around I get warnings
The image "widgets/tasks" doesn't contain any of the prefixes ("south-", "")but I think that is a false-positive.
Comment Actions
There is an issue in file desktoppackage/contents/views/Panel.qml line 57:
Instead of
prefix = [prefix, ""];
it should be
prefix = [pre, ""];
otherwise (as is currently the case) the function adjustPrefix does nothing and panels always use un-prefixed theme elements.
This has no visible impact on Breeze but it does on themes that do use prefixes in panel-background.
Comment Actions
Urgh thanks :/
Also, in future can you comment on the commit on phabricator not the review so it starts a new thread. It's very hard to find otherwise.
I only noticed this just now by accident.