Adjust plasma-desktop to the new fallback prefixes

Authored by davidedmundson on Feb 27 2017, 5:24 PM.



Grepped code for repaintNeeded on prefixes and adjusted as appropriately to match

Test Plan

Booted, looks the same.

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Feb 27 2017, 5:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 27 2017, 5:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added inline comments.

You don't take into account orientation here (south/north/west/...) which TaskTools.taskPrefix does

Fixed a stupid mistake

davidedmundson marked an inline comment as done.Feb 28 2017, 3:21 PM
broulik added inline comments.Feb 28 2017, 3:22 PM

Now you place an array inside of an array.

(btw knotifications has a unitylauncher test app where you can test this, e.g. ~/Projects/kf5-build/knotifications/tests/unitylaunchertest org.kde.dolphin --progress 50)

Proper handling of TaskProgressOverlay

broulik accepted this revision.Mar 1 2017, 9:38 AM

When I move my panel around I get warnings

The image "widgets/tasks" doesn't contain any of the prefixes ("south-", "")

but I think that is a false-positive.

This revision is now accepted and ready to land.Mar 1 2017, 9:38 AM
This revision was automatically updated to reflect the committed changes.
obnosim reopened this revision.Dec 15 2017, 10:45 PM
obnosim added a subscriber: obnosim.

There is an issue in file desktoppackage/contents/views/Panel.qml line 57:

Instead of

prefix = [prefix, ""];

it should be

prefix = [pre, ""];

otherwise (as is currently the case) the function adjustPrefix does nothing and panels always use un-prefixed theme elements.

This has no visible impact on Breeze but it does on themes that do use prefixes in panel-background.

This revision is now accepted and ready to land.Dec 15 2017, 10:45 PM

Urgh thanks :/

Also, in future can you comment on the commit on phabricator not the review so it starts a new thread. It's very hard to find otherwise.
I only noticed this just now by accident.