Having an explicit button to Cancel instead of just the option to close
the window follows other dialogs.
Labelling the accepting button with "Attach" instead of "Ok" makes it
more obvious what happens on a click, as akso recommended by
https://community.kde.org/KDE_Visual_Design_Group/HIG/Labels
Details
Details
- Reviewers
flherne - Group Reviewers
KDevelop - Commits
- R32:b5a4949aa77b: Attach-to-process dialog: add "Cancel" button, relabel "Ok" to "Attach"
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Makes sense.
There's actually a pre-existing crashybug here, but not directly related to the patch; if you don't feel like fixing it I'll try in a few days.
| debuggers/common/dialogs/processselection.cpp | ||
|---|---|---|
| 98 ↗ | (On Diff #11868) | This can happen when unsetting the selection (ctrl-click on the selected row). (not introduced by you, I just thought "wait a moment..." and tried it) |