Rename weird "Factory_ID and FactoryId" uses (NOTE)
ClosedPublic
Actions

Authored by abrahams on Oct 30 2015, 6:03 PM.

Details

Reviewers

Commits

Summary

Fixes like "ArtisticTextToolFactoryID" -> "ArtisticTextTool"
Making sure every tool has a sensible name for the .actions files

This means several files in share/krita/actions have been renamed.
Please clean out this folder after applying the patch.

Tasks: T947

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

abrahams retitled this revision from to Rename weird "Factory_ID and FactoryId" uses (NOTE).

abrahams updated this object.

abrahams edited the test plan for this revision. (Show Details)

abrahams added a reviewer: rempt.

Yes... No idea why back then the unique strings used to identify the tools needed to be burdened with fluff.

This revision is now accepted and ready to land.Nov 3 2015, 7:16 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
V			krita/data/actions/{ArtisticTextTool.action ← ArtisticTextToolFactoryID.action} (2 lines)
V			krita/data/actions/{ArtisticTextToolFactoryID.action → ArtisticTextTool.action}
M			krita/data/actions/CMakeLists.txt (6 lines)
V			krita/data/actions/{PathTool.action ← PathToolFactoryId.action} (2 lines)
V			krita/data/actions/{PathToolFactoryId.action → PathTool.action}
V			krita/data/actions/{TextTool.action ← TextToolFactory_ID.action}
V			krita/data/actions/{TextToolFactory_ID.action → TextTool.action}
M			krita/krita.action (12 lines)
M			krita/ui/canvas/kis_canvas_widget_base.cpp (2 lines)
M			krita/ui/input/kis_input_manager.cpp (2 lines)
M			krita/ui/kis_node_manager.cpp (2 lines)
M			libs/flake/tools/KoPathToolFactory.cpp (2 lines)
M			libs/flake/tools/KoZoomToolFactory.cpp (2 lines)
M			libs/widgets/KoRuler.cpp (2 lines)
M			plugins/artistictextshape/ArtisticTextToolFactory.cpp (2 lines)
M			plugins/defaultTools/defaulttool/DefaultTool.cpp (6 lines)
M			plugins/defaultTools/guidestool/GuidesTool.cpp (2 lines)
M			plugins/defaultTools/guidestool/GuidesToolFactory.h (2 lines)
M			plugins/defaultTools/guidestool/GuidesToolFactory.cpp (2 lines)
M			plugins/textshape/ReferencesToolFactory.cpp (2 lines)
M			plugins/textshape/ReviewToolFactory.cpp (2 lines)
M			plugins/textshape/TextToolFactory.cpp (2 lines)
M			plugins/vectorshape/VectorToolFactory.cpp (2 lines)