Require PAM by default and provide an option to not require it

Authored by graesslin on Feb 24 2017, 5:05 PM.



The default should be what most distros and most users/devs use.
On most distros kcheckpass would be broken without PAM. Thus not
require it is a severe issue. We have had many bug reports due to
PAM missing during build and users not able to unlock.

Slackware still requires a setup without PAM, thus a cmake option
is added to not require PAM.

cmake -DPAM_REQUIRED=OFF /path/to/kscreenlocker/src

to compile kscreenlocker without PAM support.

Test Plan

Tested cmake with and without that option

Diff Detail

R133 KScreenLocker
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Feb 24 2017, 5:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 24 2017, 5:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah accepted this revision.Mar 17 2017, 4:48 PM
bshah added a subscriber: bshah.

Looks good to me, please have packagers and distributions list in CCMAIL of commit.

This revision is now accepted and ready to land.Mar 17 2017, 4:48 PM
This revision was automatically updated to reflect the committed changes.