Make DesktopIcon aware of iamgeproviders and embedded ressources
ClosedPublic
Actions

Authored by bsonnemann on Feb 24 2017, 3:51 PM.

Details

Reviewers

Commits

Summary

Kirigami Icon on desktop environments now behave more like the qml version and respect custom image providers as well as embedded resources

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart accepted this revision.Mar 2 2017, 4:08 PM

mart added inline comments.

src/desktopicon.cpp
145 ↗	(On Diff #11775)	use {} also for one line ifs

This revision is now accepted and ready to land.Mar 2 2017, 4:08 PM

src/desktopicon.cpp
257 ↗	(On Diff #11775)	{} not needed here

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/desktopicon.h (7 lines)
M			src/desktopicon.cpp (121 lines)
M			src/kirigamiplugin.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11775			Feb 24 2017, 3:48 PM	★	★
Diff 2	12146	a90b442	R169:3553ca6d414764dc72c2415099bf2f87f1a93918	Mar 3 2017, 6:43 PM	★	★