- Uses resources instead of relying on executing the application in the source
directory.
- Uses QQmlApplicationEngine instead of QQuickView
- Doesn't introduce weird logic as if the user had to learn QML by looking at
the template.
kfunk |
KDevelop |
directory.
the template.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
+1 on the idea
app_templates/cpp/CMake/cmake_qt5-qml2/cmake_qt5-qml2.kdevtemplate | ||
---|---|---|
4 | Kill all the other translated lines? I'm not sure it's needed, but it gives me a warm feeling :P | |
app_templates/cpp/CMake/cmake_qt5-qml2/qt5-qml2.png | ||
1 | The preview image doesn't match what you have in the main.qml, no? I think you should at least keep some text in the main.qml, e.g. "Hello World". |
app_templates/cpp/CMake/cmake_qt5-qml2/cmake_qt5-qml2.kdevtemplate | ||
---|---|---|
4 | Scripty will do it π |
app_templates/cpp/CMake/cmake_qt5-qml2/CMakeLists.txt | ||
---|---|---|
7 | All the other templates in app_templates/ use APPNAMELC here. Looks like the better choice, considering that you could have a whitespace char in the dir name? | |
10 | Minor: Remove extra newlines | |
app_templates/cpp/QMake/qt5-qml2/src/qml/main.qml | ||
12 | Why no Text{} element at least? Now that's a boring example you have here! |
Address comments
app_templates/cpp/QMake/qt5-qml2/src/qml/main.qml | ||
---|---|---|
12 | It's not an example, it's a template! |
app_templates/cpp/QMake/qt5-qml2/src/qml/main.qml | ||
---|---|---|
12 | Phew. Whatever. :) |