Differential D470

Change OPML filter string for file dialog so they can actually be selected
ClosedPublic
Actions

Authored by akowalski on Oct 28 2015, 10:32 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Summary

In Akregator it is currently not possible to open *.opml files in the Import Feeds dialog with the OPML Outline Filter selected because the string contains a comma where it should not. This fixes it.

Diff Detail

Repository
R43 KDE PIM
Lint
Lint Skipped
Unit
Unit Tests Skipped
akowalski updated this revision to Diff 1083.Oct 28 2015, 10:32 PM
akowalski retitled this revision from to Change OPML filter string for file dialog so they can actually be selected.
akowalski updated this object.
akowalski edited the test plan for this revision. (Show Details)
akowalski added a reviewer: KDE PIM.
akowalski set the repository for this revision to R43 KDE PIM.
akowalski added a project: KDE PIM.
mlaurent added a subscriber: mlaurent.Oct 29 2015, 5:54 AM

Seems good.
Ship it.
Do you have account ?

akowalski added a comment.Oct 29 2015, 3:58 PM
In D470#9012, @mlaurent wrote:

Seems good.
Ship it.
Do you have account ?

No, I don't.
Will you commit it or should I get one?

mlaurent added a comment.Oct 29 2015, 5:09 PM

I can commit for you if you want

akowalski added a comment.Oct 30 2015, 7:56 AM
In D470#9143, @mlaurent wrote:

I can commit for you if you want

Yes, please do that.
Thanks.

mlaurent added a comment.Oct 30 2015, 8:50 AM

Ok I will do soon.
Thanks for the patch.

mlaurent accepted this revision.Oct 30 2015, 9:58 AM
mlaurent added a reviewer: mlaurent.
This revision is now accepted and ready to land.Oct 30 2015, 9:58 AM
aacid closed this revision.Feb 26 2017, 11:09 PM

Revision Contents
Changeset List

PathPackages
Makregator/src/akregator_part.cpp (4 lines)

Diff 1083

View Options

akregator/src/akregator_part.cpp

Loading...