app/batchextract.cpp
173	You can remove the last two arguments, they already take a default value
part/part.cpp
1035	Use `KRun::RunFlags()` rather than 0. And same as above, you can drop the last 2 arguments
1265	Same here, QString() and QByteArray not necessary

This revision now requires changes to proceed.Feb 20 2017, 9:06 PM

Use KRun::RunFlags() as fourth argument.

rthomsen marked an inline comment as done.Feb 21 2017, 7:17 PM

rthomsen added inline comments.

app/batchextract.cpp
173	If they are removed the old overload will be used and the deprecation warning emitted.
part/part.cpp
1265	Same as above.

elvisangelaccio added inline comments.

app/batchextract.cpp
173	hmm right, it would need the extended `KRun::RunFlags(KRun::RunExecutables)` version, which is no longer less verbose... Ok, forget it then.

This revision is now accepted and ready to land.Feb 21 2017, 8:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11563			Feb 20 2017, 8:46 PM	★	★
Diff 2	11602			Feb 21 2017, 7:13 PM	★	★
Diff 3	11635	fc156de	R36:63db16ce43a5689a5d5ee8ba152a45b7228fdbe0	Feb 22 2017, 5:19 PM	★	★

Diff 11635