Differential D4659

Improve KStars tests double/float comparisons
ClosedPublic
Actions

Authored by joselema on Feb 18 2017, 1:42 PM.

Details

Reviewers
mutlaqja
ckertesz
Summary

See https://bugs.kde.org/show_bug.cgi?id=376439

Test Plan

I have tested that this patch ..

  1. In a kubuntu zesty amd64 against the master branch. The patch doesn't break the tests, apparenly.
  2. In a kubuntu zesty amd64 against the Applications/16.12 branch. The patch doesn't break the tests, apparenly.
  3. Applying this patch exactly as it is to the current 16.12.1 kubuntu's package. It was built succesfully.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
joselema created this revision.Feb 18 2017, 1:42 PM
ckertesz accepted this revision.Aug 13 2017, 8:38 AM
ckertesz added a subscriber: ckertesz.

I already committed these changes this week after porting the patch to the current codebase.

This revision is now accepted and ready to land.Aug 13 2017, 8:38 AM
ckertesz closed this revision.Jul 24 2018, 4:24 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 24 2018, 4:24 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript

Revision Contents
Changeset List

Diff 11478

View Options

Tests/auxiliary/testcachingdms.cpp

Loading...
View Options

Tests/auxiliary/testdms.cpp

Loading...