Make the ItemViewHeader more similar to Discover's Header design
ClosedPublic
Actions

Authored by apol on Feb 17 2017, 5:51 PM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

Summary

This way we make sure it's being used and we possibly ensure some uniformity
on applications visual appearance.

Test Plan

works for kirigami2gallery and discover

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol retitled this revision from to Make the ItemViewHeader more similar to Discover's Header design.

apol updated this object.

apol edited the test plan for this revision. (Show Details)

apol added reviewers: Plasma, mart.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart edited edge metadata.

mart added inline comments.

src/controls/ItemViewHeader.qml
66 ↗	(On Diff #11463)	linkColor? is it actually a link? highlightColor makes more semantic sense and should be the same color iirc by default?
91 ↗	(On Diff #11463)	also here linkColor->highlightColor?

This revision is now accepted and ready to land.Feb 17 2017, 7:37 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/controls/AbstractItemViewHeader.qml (6 lines)
M			src/controls/ItemViewHeader.qml (43 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11463	10c784a		Feb 17 2017, 5:51 PM	★	★
Diff 2	11472	10c784a	R169:4f25212d83429fb60c4496691b5ff00d9a1eb902	Feb 17 2017, 11:29 PM	★	★