Differential D4642

Don't open nonexistent documents from problems view + assertion fix
ClosedPublic
Actions

Authored by antonanikin on Feb 17 2017, 2:41 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:ab0bbcba75aa: Don't open nonexistent documents from problems view + assertion fix
R33:ab0bbcba75aa: Don't open nonexistent documents from problems view + assertion fix
Summary

Previous version always call documentController to open current problem item. This leads to open new (empty) documents for items with finalLocation() refers to nonexistent document. Such items produced by some analyzers plugins like Cppcheck or Valgrind.

The patch also fixes assertion from shell/documentcontroller.cpp:218:

Q_ASSERT(!inputUrl.isRelative());

This assertion caused, for example, by problems with empty finalLocation() (displayed as "/" in view).

Test Plan

Tested on master branch

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin updated this revision to Diff 11425.Feb 17 2017, 2:41 AM
antonanikin retitled this revision from to Don't open nonexistent documents from problems view.
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added a reviewer: KDevelop.
antonanikin added a subscriber: kdevelop-devel.
antonanikin retitled this revision from Don't open nonexistent documents from problems view to Don't open nonexistent documents from problems view + assertion fix.Feb 17 2017, 4:36 AM
antonanikin updated this object.
kfunk accepted this revision.Feb 17 2017, 7:39 AM
kfunk added a reviewer: kfunk.
This revision is now accepted and ready to land.Feb 17 2017, 7:39 AM
Closed by commit R33:ab0bbcba75aa: Don't open nonexistent documents from problems view + assertion fix (authored by antonanikin). · Explain WhyFeb 17 2017, 8:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11436

View Options

plugins/problemreporter/problemtreeview.cpp

Loading...