Don't open nonexistent documents from problems view + assertion fix

Authored by antonanikin on Feb 17 2017, 8:01 AM.

Description

Don't open nonexistent documents from problems view + assertion fix

Summary:
Previous version always call documentController to open current problem item. This leads to open new (empty) documents for items with finalLocation() refers to nonexistent document. Such items produced by some analyzers plugins like Cppcheck or Valgrind.

The patch also fixes assertion from shell/documentcontroller.cpp:218:

Q_ASSERT(!inputUrl.isRelative());

This assertion caused, for example, by problems with empty finalLocation() (displayed as "/" in view).

Test Plan: Tested on master branch

Reviewers: KDevelop, kfunk

Reviewed By: KDevelop, kfunk

Subscribers: kdevelop-devel

Differential Revision: https://phabricator.kde.org/D4642

Details

Committed
antonanikinFeb 17 2017, 8:01 AM
Reviewer
KDevelop
Differential Revision
D4642: Don't open nonexistent documents from problems view + assertion fix
Parents
R32:5ad012aa9e85: Assertion fix for ProblemModel
Branches
Unknown
Tags
Unknown