Launch config dialog: use standard button text Add/Remove, use QPushButton
ClosedPublic

Authored by kossebau on Feb 12 2017, 12:38 AM.

Details

Summary

Old text "Add New..." and "Remove Selected" were not following standard
naming of such buttons in KDevelop, also could result in longer translations
making the row minimum width quite large.
The "..." also indicates another dialog usually, not just a popup list.
Instead a popup indicator arrow is now used as in similar places.

These Add/Remove buttons usually are also below or to the right of the
object, not above. But moving below the list made the whole dialog
look more strange, so not done here, needs a bigger overhaul of the
whole dialog.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 11243.Feb 12 2017, 12:38 AM
kossebau retitled this revision from to Launch config dialog: use standard button text Add/Remove, use QPushButton.
kossebau updated this object.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 12 2017, 12:38 AM

Before:

After:

antonanikin accepted this revision.Feb 12 2017, 1:08 AM
antonanikin added a reviewer: antonanikin.
This revision is now accepted and ready to land.Feb 12 2017, 1:08 AM
mwolff accepted this revision.Feb 12 2017, 11:40 AM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

lgtm, thanks

This revision was automatically updated to reflect the committed changes.