Differential D4555

Fix Bug 374458 by properly blocking signals on debugger combo box
ClosedPublic
Actions

Authored by qi437103 on Feb 10 2017, 9:22 PM.

Details

Reviewers
apol
flherne
Group Reviewers
KDevelop
Commits
R33:7aa07c93de95: Fix Bug 374458 by properly blocking signals on debugger combo box
R32:7aa07c93de95: Fix Bug 374458 by properly blocking signals on debugger combo box
Summary

Fix https://bugs.kde.org/show_bug.cgi?id=374458

In the launch configuration dialog, when changing config page and updating the debugger combo box, signals are not properly
blocked, thus triggering incorrect setData call on the model. Bug 374458 happens only when GDB is choosen as debugger because GDB
happens to be the second item in the combo box.

Test Plan

Maunally tested, no more crash.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
qi437103 updated this revision to Diff 11193.Feb 10 2017, 9:22 PM
qi437103 retitled this revision from to Fix Bug 374458 by properly blocking signals on debugger combo box.
qi437103 updated this object.
qi437103 edited the test plan for this revision. (Show Details)
qi437103 added a reviewer: apol.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 10 2017, 9:22 PM
qi437103 updated this object.Feb 10 2017, 9:23 PM
qi437103 added a reviewer: KDevelop.
flherne accepted this revision.Feb 11 2017, 11:19 AM
flherne added a reviewer: flherne.
flherne added a subscriber: flherne.

Yes, this does fix the bug for me, and the patch makes sense.

This revision is now accepted and ready to land.Feb 11 2017, 11:19 AM
Closed by commit R33:7aa07c93de95: Fix Bug 374458 by properly blocking signals on debugger combo box (authored by qi437103). · Explain WhyFeb 11 2017, 4:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11229

View Options

shell/launchconfigurationdialog.cpp

Loading...