Differential D4536

Fix archivemodel columns with singlefile archives
ClosedPublic
Actions

Authored by elvisangelaccio on Feb 9 2017, 6:25 PM.

Details

Reviewers
rthomsen
Commits
R36:c1a72a8e053a: Fix archivemodel columns with singlefile archives
Summary

ArchiveModel was setting 0 as Size with singlefile archives,
because the singlefile plugin doesn't report the uncompressed size.

This patch removes the Size column if the size property is 0 but the
compressedSize one is higher than 0, which cannot happen.
As compressedSize for singlefile entries, we just set the size of the
archive.

BUG: 376225
FIXED-IN: 16.12.3

Test Plan

Open a gzipped file and check the columns in the archiveview, with/without
patch.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 11131.Feb 9 2017, 6:25 PM
elvisangelaccio retitled this revision from to Fix archivemodel columns with singlefile archives.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptFeb 9 2017, 6:25 PM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Feb 12 2017, 11:32 AM
rthomsen edited edge metadata.
This revision is now accepted and ready to land.Feb 12 2017, 11:32 AM

Revision Contents
Changeset List

Diff 11278

View Options

part/archivemodel.cpp

Loading...
View Options

plugins/libsinglefileplugin/singlefileplugin.cpp

Loading...