Allow to configure import commit message for all DVCS systems
ClosedPublic

Authored by kossebau on Feb 9 2017, 2:01 AM.

Details

Summary

Currently the standard vcs import metadata widget for DVCS
has not supported the editing of the message used for the import
commit, other than the custom widget for SVN or CVS.
Instead the message was hardcoded.

This patch changes this to allow editing of the commit message
also for any DVCS using DvcsImportMetadataWidget, by
extending it with a text edit field for the message
and changing the code doing the commit to use the existing
message query API to get the commit message.

For having some default text in the editor, also for SVN & CVS
which currently start with an empty message, the
VcsImportMetadataWidget API gets also a setter for the message,
by which then a global default message is preset in the editor.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 11089.Feb 9 2017, 2:01 AM
kossebau retitled this revision from to Allow to configure import commit message for all DVCS systems.
kossebau updated this object.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 9 2017, 2:01 AM

By example of git:

Before:

After:

kossebau updated this revision to Diff 11090.Feb 9 2017, 2:06 AM

fix typo

brauch accepted this revision.Feb 9 2017, 5:36 PM
brauch added a reviewer: brauch.
brauch added a subscriber: brauch.

Looks fine to me, thanks!

This revision is now accepted and ready to land.Feb 9 2017, 5:36 PM
This revision was automatically updated to reflect the committed changes.