Revise investment transaction report
ClosedPublic
Actions

Authored by wojnilowicz on Feb 5 2017, 1:44 PM.

Details

Reviewers

Group Reviewers

Summary

Price of transaction should be taken from transaction and not from
stored prices.
Investment accounts should report asset split as main split for correct
amount value, as it contains fees.
BUG:365306
BUG:373966
Signed-off-by: Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com>

Diff Detail

Repository

R261 KMyMoney

Lint

Lint Skipped

Unit

Unit Tests Skipped

wojnilowicz updated this revision to Diff 10934.Feb 5 2017, 1:44 PM

wojnilowicz retitled this revision from to Revise investment transaction report.

wojnilowicz updated this object.

wojnilowicz edited the test plan for this revision. (Show Details)

wojnilowicz added a reviewer: KMyMoney.

Investment transactions report look like on the following image

and after this patch it will look like on the following image

wojnilowicz set the repository for this revision to R261 KMyMoney.Feb 5 2017, 3:42 PM

wojnilowicz added a project: KMyMoney.

wojnilowicz added a subscriber: KMyMoney.

New version of patch:
-fixes bug 373966,
-is aware that you have transaction e.g. between USD and GBP accounts and your base currency is e.g. PLN

wojnilowicz updated this revision to Diff 11125.Feb 9 2017, 5:25 PM

wojnilowicz updated this object.

Looks good to me

This revision is now accepted and ready to land.Feb 17 2017, 12:40 PM

Submitted.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/reports/querytable.cpp (144 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	10934	d1831bb		Feb 5 2017, 1:44 PM	★	★
Diff 2	11124	c6aa6e3	New version of patch:	Feb 9 2017, 5:23 PM	★	★
Diff 3	11125			Feb 9 2017, 5:24 PM	★	★

Diff 11125

View Options

kmymoney/reports/querytable.cpp