File template dialog: several small UI/UX improvements
ClosedPublic

Authored by kossebau on Feb 1 2017, 2:36 PM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Summary

Small improvements collected in the last weeks, for
review in one go, but possibly to be split up in commits,
also some for master and some for 5.1.

  • turn newclass.ui & testcases.ui into QFormLayout + fix bad automatic tab order in testcases.ui + "Inheritance:" label now properly aligned with lineedit + remove unneeded extra layout layers
  • workaround for broken focus handling in KEditListWidget on "Add" button clicks or "Remove" with last item
  • use generic "generated content" instead of "new class" in pages which are also used for non-class templates
  • use i18np instead of static "Output file(s)" on output page
  • use ICore::self()->projectController()->projectsBaseDirectory() as fallback starting folder, not QDir::homePath()
  • add a placeholder text to class identifier lineedit which hints that namespace can be entered there as well (was not obvious to me :) )

Diff Detail

Repository
R33 KDevPlatform
Branch
pimpFileTemplateDialog
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 10823.Feb 1 2017, 2:36 PM
kossebau retitled this revision from to File template dialog: several small UI/UX improvements.
kossebau updated this object.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 1 2017, 2:36 PM
apol accepted this revision.Feb 1 2017, 2:41 PM
apol added a reviewer: apol.
This revision is now accepted and ready to land.Feb 1 2017, 2:41 PM
kossebau closed this revision.Feb 1 2017, 9:23 PM

Thanks for review. Splitted into commits for master

  • f5545d573b1c38d0fcea9e152f432f916a26d2e3
  • 7b163d6ae6ac511d6e2d0280657e57afee7d3c1d
  • f7e04327598672e10f982d126e417e96903c3557

and 5.1

  • fdc9987cac51283bd376355887191ddd6efcab67
  • 84d657eecd4e58f99eb88349b9af8409519bfa6d
  • f03432e3cbc9608f3657f5e36d12a385dabcbb86

and pushed.