Differential D4383

Fix memory leak
AbandonedPublic
Actions

Authored by davidedmundson on Jan 31 2017, 11:30 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

KProcess is allocated but never deleted

Test Plan

Ran krunner
typed "kill firefox"
it died

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 10792.Jan 31 2017, 11:30 PM
davidedmundson retitled this revision from to Fix memory leak.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2017, 11:30 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a subscriber: apol.Feb 1 2017, 12:00 AM
apol added inline comments.
runners/kill/killrunner.cpp
186

If what you want is just to fix the leak putting it in the stack would be the obvious thing to do.

OTOH, we don't really want it to block, maybe you could turn it into a lambda that calls the KAuth fallback? (or a slot).

Then deleting would mean to connect the finished to deleteLater.

davidedmundson abandoned this revision.Mar 7 2017, 11:32 AM

someone else wrote just put the same thing on RB. May as well let them ship theirs.

Revision Contents
Changeset List

PathPackages
Mrunners/kill/killrunner.cpp (4 lines)

Diff 10792

View Options

runners/kill/killrunner.cpp

Loading...