Differential D4353

[Applet Configuration] Add mnemonics for dialog buttons
AbandonedPublic
Actions

Authored by broulik on Jan 30 2017, 4:33 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

Unfortunately due to the way Breeze style and QtQuick Controls 1 work you cannot see them unless you hold Alt and then hover the button to trigger an update. At least you can press Alt+O/C/A (or localized variants) now to okay/cancel/apply.

Test Plan

Dunno how to hint this to translators properly - in German "Abbrechen" would be A whereas "Anwenden" should become "N"... we don't get this automatism we have with widgets :(

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 10732.Jan 30 2017, 4:33 PM
broulik retitled this revision from to [Applet Configuration] Add mnemonics for dialog buttons.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 30 2017, 4:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested changes to this revision.Jan 23 2018, 12:45 PM
davidedmundson added a subscriber: davidedmundson.

Is this the right approach given the auto mnemoics stuff Marco wrote which is merged now?

This revision now requires changes to proceed.Jan 23 2018, 12:45 PM
broulik added a comment.Jan 23 2018, 1:29 PM

I think the auto mnemonic stuff only affects QQC2?

broulik planned changes to this revision.Apr 24 2018, 5:34 PM

Just tried, porting it to QQC2 will give it auto mnemonics \o/ will look into that

broulik abandoned this revision.Apr 25 2018, 2:58 PM

Let's not hijack this review for a potential QQC2 port

Revision Contents
Changeset List

Diff 10732

View Options

desktoppackage/contents/configuration/AppletConfiguration.qml

Loading...