Introduce unit test for mimetype detection
ClosedPublic
Actions

Authored by elvisangelaccio on Oct 19 2015, 9:22 PM.

Details

Reviewers

Commits

R36:11c94a48e076: Introduce unit test for mimetypes detection

Summary

While reasoning on bug 328815, I noticed that the static method determineMimeType defined in archive_kerfuffle.cpp is a good candidate to be unit tested. To do so, we need to make it visible from the outside.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 1019.Oct 19 2015, 9:22 PM

elvisangelaccio retitled this revision from to Introduce mimetypetest.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptOct 19 2015, 9:22 PM

elvisangelaccio retitled this revision from Introduce mimetypetest to Introduce unit test for mimetype detection.Oct 19 2015, 9:28 PM

elvisangelaccio updated this object.

elvisangelaccio added a project: Ark.

Looks good :)

This revision is now accepted and ready to land.Oct 20 2015, 4:17 PM

Closed by commit R36:11c94a48e076: Introduce unit test for mimetypes detection (authored by elvisangelaccio). · Explain WhyOct 20 2015, 5:58 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:11c94a48e076: Introduce unit test for mimetypes detection.

Revision Contents
Changeset List

			Path
M			kerfuffle/archive_kerfuffle.h (7 lines)
M			kerfuffle/archive_kerfuffle.cpp (13 lines)
M			kerfuffle/tests/CMakeLists.txt (1 line)
A	M	(bin)	kerfuffle/tests/data/zip_with_wrong_extension.rar
A	M		kerfuffle/tests/mimetypetest.cpp (63 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1019	35a101b		Oct 19 2015, 9:22 PM	★	★
Diff 2	1022	35a101b	Commit rARK11c94a48e076702dae200c216f7edfe891bf9409	Oct 20 2015, 5:54 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
94d1493427f1	dede6364ea01	989ecbc1f220	Elvis Angelaccio	Add test file	Oct 19 2015, 9:20 PM
989ecbc1f220	de2abc7f0833	824bb532b252	Elvis Angelaccio	Change the wrong extension	Oct 19 2015, 9:18 PM
824bb532b252	a977e573bcbf	35a101bdf9d6	Elvis Angelaccio	Introduce mimetypetest	Oct 19 2015, 9:13 PM