- Add support for data and binary elements.
- Support loading images from embedded data.
Details
Details
- Reviewers
leinir - Group Reviewers
Peruse - Commits
- R157:4cdb7ebff47d: Add support for images embedded in the .acbf file
Can read comics where the images are embedded in the .acbf file.
Diff Detail
Diff Detail
- Repository
- R157 Peruse
- Branch
- acbf-embedded-data
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
With that minor caveat in the archive image provider, this looks good to me! :)
| src/qtquick/ArchiveImageProvider.cpp | ||
|---|---|---|
| 63 | A comment to describe the logic here would be good :) (i know it's just because that's how ACBF does references internally, but it'd be good to make that explicit, perhaps with a link to the standard?) | |