Differential D4294

Latex Syntax: Fix identification of alignat environment end
ClosedPublic
Actions

Authored by hfujimoto on Jan 26 2017, 12:24 PM.

Details

Reviewers
None
Group Reviewers
Framework: Syntax Highlighting
Commits
R216:540fb97a8764: LaTeX highlighting: fix alignat environment
Summary

Avoid identifying alignat as align in environment end.
fix of bug 344562: https://bugs.kde.org/show_bug.cgi?id=344562

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hfujimoto updated this revision to Diff 10584.Jan 26 2017, 12:24 PM
hfujimoto retitled this revision from to Latex Syntax: Fix identification of alignat environment end.
hfujimoto updated this object.
hfujimoto edited the test plan for this revision. (Show Details)
hfujimoto added a reviewer: Framework: Syntax Highlighting.
hfujimoto set the repository for this revision to R216 Syntax Highlighting.
hfujimoto added a project: Framework: Syntax Highlighting.
hfujimoto added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 26 2017, 12:24 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann added a subscriber: dhaumann.Jan 26 2017, 6:35 PM

The patch is almost good: Whenever we change a .xml file, we also need to increase the version number in <langauge version="x". Could you increase this number by 1? Then, we can approve this patch.

Also, do you have commit access?

hfujimoto updated this revision to Diff 10645.Jan 27 2017, 10:52 PM

increse version number.

hfujimoto added a comment.Jan 27 2017, 10:53 PM

@dhaumann
I don't have commit access.

hfujimoto updated this revision to Diff 10646.Jan 27 2017, 10:57 PM

oh, I missed.
I should not change xml version but also language version.

Closed by commit R216:540fb97a8764: LaTeX highlighting: fix alignat environment (authored by dhaumann). · Explain WhyFeb 5 2017, 1:31 PM
This revision was automatically updated to reflect the committed changes.
dhaumann mentioned this in R216:540fb97a8764: LaTeX highlighting: fix alignat environment.

Revision Contents
Changeset List

Diff 10931

View Options

autotests/folding/highlight.tex.fold

Loading...
View Options

autotests/html/highlight.tex.html

Loading...
View Options

autotests/input/highlight.tex

Loading...
View Options

autotests/reference/highlight.tex.ref

Loading...
View Options

data/syntax/latex.xml

Loading...