Differential D4285

When swapping Wallpapers, save the config to file, not just to propertymap
ClosedPublic
Actions

Authored by davidedmundson on Jan 25 2017, 9:32 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:a9f5ada73bf8: When swapping Wallpapers, save the config to file, not just to propertymap
R120:a9f5ada73bf8: When swapping Wallpapers, save the config to file, not just to propertymap
Summary

ContainmentConfigView has a special code path for wallpaper configs
where, if you change wallpaper type, it will create a temporary config
ConfigPropertyMap, then copy it over to the real config when the
containment actually changes.

ConfigPropertyMap does not call valueChanged() on insertion (See
QQmlPropertyMap), and we only write the value into the actual
KConfigSkeleton on valueChange.

BUG: 375532

Test Plan

Start plasma with image wallpaper
Set to colour wallpaper and save colour
Hit apply

Close plasma
Start plasma

Before the correct colour wouldn't be loaded. Now it is.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10567.Jan 25 2017, 9:32 PM
davidedmundson retitled this revision from to When swapping Wallpapers, save the config to file, not just to propertymap.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 25 2017, 9:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 26 2017, 4:03 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 26 2017, 4:03 PM
Closed by commit R120:a9f5ada73bf8: When swapping Wallpapers, save the config to file, not just to propertymap (authored by davidedmundson). · Explain WhyJan 26 2017, 4:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/containmentconfigview.cpp (4 lines)

Diff 10598

View Options

shell/containmentconfigview.cpp

Loading...