Drop restriction on when to emit the keyboard layout changed OSD
ClosedPublic

Authored by graesslin on Jan 22 2017, 11:18 AM.

Details

Summary

We had bound this to whether we use libinput as the keyboard layout
change got emitted from within our Xkb class. This class gets used
also on X11 for modifier only shortcuts.

With the latest changes the notification got split out from Xkb into
an own class which is not used on X11 any more. Thus the check is no
longer used.

By removing the check we can test the OSD in a nested setup.

Test Plan

OSD is shown when running a nested Plasma

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 10431.Jan 22 2017, 11:18 AM
graesslin retitled this revision from to Drop restriction on when to emit the keyboard layout changed OSD.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptJan 22 2017, 11:18 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
bshah accepted this revision.Jan 22 2017, 11:33 AM
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.Jan 22 2017, 11:33 AM
This revision was automatically updated to reflect the committed changes.