Details
Diff Detail
- Repository
- R14 KReport
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
examples/KReportExampleData.h | ||
---|---|---|
28 |
| |
src/common/KReportDataSource.h | ||
90 | int -> int pos | |
105–106 | an expression -> a condition Previous condition, if there is any, is joined using "AND" operator | |
106–107 | Perhaps relation would be better const QString& because how can be ">=" supplied otherwise? | |
133 | Why is it needed? Constructor would be enough. The create() does not supply a proper plugin behavior I am afraid... | |
src/common/KReportItemBase.h | ||
93 | data -> source | |
src/plugins/web/KReportItemWeb.h | ||
24–25 | <KReportDataSource.h> for consistency since it's outside of KReport DLL | |
src/renderer/KReportOneRecordDataSource_p.h | ||
29 | Data -> data source | |
37 |
| |
src/renderer/KReportPreRenderer.cpp | ||
658 | data -> dataSource | |
src/renderer/KReportPreRenderer.h | ||
52 | data -> dataSource | |
src/renderer/KReportPreRenderer_p.h | ||
61–62 | -> m_dataSource | |
src/renderer/scripting/KReportScriptHandler.cpp | ||
46 | -> reportDataSource | |
63 | kodata -> dataSource | |
src/wrtembed/KReportDesigner.cpp | ||
185 | kordata -> dataSource | |
444 |
| |
src/wrtembed/KReportDesigner.h | ||
77 |
| |
83 |
|
src/common/KReportDataSource.h | ||
---|---|---|
133 | It is used in the KexiDBReportData implementation. It allows to create an instance of a subclass, without knowing about the implementation. Again, like the dataSourceNames/Captions, it is used in advanced controls like the the chart plugin, to create another datasource given its name. Would you like it implemented differently? |
Good job, sorry for the delay.
src/common/KReportDataSource.h | ||
---|---|---|
133 | It's OK for now! Thanks for the info. |