Remove unused feature "favorite" from PlasmaAppletItemModel
ClosedPublic

Authored by davidedmundson on Jan 20 2017, 3:06 AM.

Details

Summary

There was no role exposed for isFavorite and it has no other impact.
Removing it not only cleans up the code but also saves us parsing a
config file for no reason.

I don't think it's worth putting in the UI; no-one is adding so many
plasmoids that they would go out of their way to mark one as a favourite
for quicker future access.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Remove unused feature "favorite" from PlasmaAppletItemModel.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 20 2017, 3:06 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 23 2017, 4:49 PM
mart added a reviewer: mart.
mart added a subscriber: mart.

fun fact: this was used only in the first qwidget-based widget explorer, used only until KDE 4.2

This revision is now accepted and ready to land.Jan 23 2017, 4:49 PM
This revision was automatically updated to reflect the committed changes.