Differential D4206

Improve how we deal with dbus errors from the cli
ClosedPublic
Actions

Authored by apol on Jan 19 2017, 7:01 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:339ce7beea6b: Improve how we deal with dbus errors from the cli
Summary

Always use pending calls and centralize dbus error management

Diff Detail

Repository
R224 KDE Connect
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 10364.Jan 19 2017, 7:01 PM
apol retitled this revision from to Improve how we deal with dbus errors from the cli.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: KDE Connect, albertvaka.
albertvaka added inline comments.Jan 19 2017, 7:34 PM
cli/kdeconnect-cli.cpp
41

Maybe return an empty T() here? Otherwise, I think QDbus goes loco and returns the error message as the value. Would be nice if you can test it first, maybe it's no longer the case?

apol updated this revision to Diff 10380.Jan 20 2017, 3:46 AM

Better error handling

albertvaka added inline comments.Jan 20 2017, 9:26 AM
cli/kdeconnect-cli.cpp
56 ↗(On Diff #10380)

Also quit the app in this case?

apol updated this revision to Diff 10506.Jan 24 2017, 7:18 PM

Exit on error

albertvaka accepted this revision.Jan 24 2017, 7:19 PM
albertvaka edited edge metadata.
This revision is now accepted and ready to land.Jan 24 2017, 7:19 PM

Revision Contents
Changeset List

PathPackages
Mcli/kdeconnect-cli.cpp (65 lines)

Diff 10506

View Options

cli/kdeconnect-cli.cpp

Loading...