Differential D4177

Hide menu if the menu disappears off DBus
ClosedPublic
Actions

Authored by davidedmundson on Jan 17 2017, 7:37 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:162543b7eb89: Hide menu if the menu disappears off DBus
R120:162543b7eb89: Hide menu if the menu disappears off DBus
Summary

This can happen without a focus change if focus is changed to a window
that doesn't claim the menu, for example the desktop.

It could also happen if an application does something weird, like release
its service name.

Test Plan

Ran "sleep 10; killall kate"
Then selected kate then the desktop
Kate remained showing for 10 seconds then closed

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10295.Jan 17 2017, 7:37 PM
davidedmundson retitled this revision from to Hide menu if the menu disappears off DBus.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2017, 7:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Jan 17 2017, 8:49 PM
broulik added a reviewer: broulik.
broulik added a subscriber: broulik.

Bug 374995?

This revision is now accepted and ready to land.Jan 17 2017, 8:49 PM
broulik added inline comments.Jan 17 2017, 8:54 PM
applets/appmenu/plugin/appmenumodel.cpp
35

Unused

Closed by commit R120:162543b7eb89: Hide menu if the menu disappears off DBus (authored by davidedmundson). · Explain WhyJan 17 2017, 8:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10302

View Options

applets/appmenu/plugin/appmenumodel.cpp

Loading...