Differential D4163

pre-load the first layer of sub menus
ClosedPublic
Actions

Authored by davidedmundson on Jan 16 2017, 3:54 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:6ed2c4a32b61: pre-load the first layer of sub menus
R120:6ed2c4a32b61: pre-load the first layer of sub menus
Summary

We still call aboutToShow on them inside libdbusmenu-qt and update the
menu whilst it's showing, but having it pre-populated makes it look a
bit faster.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10244.Jan 16 2017, 3:54 PM
davidedmundson retitled this revision from to pre-load the first layer of sub menus.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2017, 3:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Jan 16 2017, 5:04 PM
broulik added a reviewer: broulik.
broulik added a subscriber: broulik.
broulik added inline comments.
applets/appmenu/plugin/appmenumodel.cpp
238

coding style: for (…) {

This revision is now accepted and ready to land.Jan 16 2017, 5:04 PM
broulik added a comment.Jan 16 2017, 5:06 PM

Same could be done in decoration appmenu

Closed by commit R120:6ed2c4a32b61: pre-load the first layer of sub menus (authored by davidedmundson). · Explain WhyJan 17 2017, 8:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 10299

View Options

applets/appmenu/plugin/appmenumodel.cpp

Loading...