associate with deb and rpm to expose local file install capability
ClosedPublic

Authored by sitter on Jan 13 2017, 11:43 AM.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter updated this revision to Diff 10128.Jan 13 2017, 11:43 AM
sitter retitled this revision from to associate with deb and rpm to expose local file install capability.
sitter updated this object.
sitter edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptJan 13 2017, 11:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol accepted this revision.Jan 13 2017, 11:45 AM
apol added a reviewer: apol.
apol added a subscriber: apol.

This is good for now.

I wonder if we should have separate desktop files, like okular does...

This revision is now accepted and ready to land.Jan 13 2017, 11:45 AM
This revision was automatically updated to reflect the committed changes.

That may well be overengineering the solution. I think it'd be fine to configure_file the desktop file and build the list of miemtypes programmatically at build time and let packagers override it.
Separate mimetype files would only be useful if platform 'foo' has >1 packagekit backend and the list of supported formats is different between the backends. Which I think is not the case for any right now.

That being said, should it become necessary, separate files would be the way to go.
For packagers this is then representable as

  • pk-backend-foo --(depends)--> discover-backend-foo [only contains desktop file]
  • pk-backend-bar --(depends)--> discover-backend-bar [only contains desktop file]