Differential D4098

Clang: Also rename destructors when renaming class
ClosedPublic
Actions

Authored by kfunk on Jan 12 2017, 8:28 AM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Commits
R32:51658b812040: Clang: Also rename destructors when renaming class
Summary

BUG: 373452
FIXED-IN: 5.0.4

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk updated this revision to Diff 10087.Jan 12 2017, 8:28 AM
kfunk retitled this revision from to Clang: Also rename destructors when renaming class.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 12 2017, 8:28 AM
apol added a subscriber: apol.Jan 12 2017, 11:54 AM

Obviously this was nitpicking. Clearly fixes a bug and it's tested.
+1

languages/clang/tests/test_refactoring.cpp
74

Wouldn't it be better for the tests to have separate before.cpp and after.cpp files?

Then we could do things like:

action before.cpp > generated.cpp
diff generated.cpp after.cpp
languages/clang/tests/test_refactoring.h
21–22

TESTREFACTORING_H?

kfunk updated this revision to Diff 10121.Jan 13 2017, 8:01 AM

Fix issues mentioned

kfunk marked 2 inline comments as done.Jan 13 2017, 8:02 AM

Fixed

apol accepted this revision.Jan 15 2017, 11:14 PM
apol added a reviewer: apol.

Looks good to me, from my ignorance on Clang's internals.

This revision is now accepted and ready to land.Jan 15 2017, 11:14 PM
Closed by commit R32:51658b812040: Clang: Also rename destructors when renaming class (authored by kfunk). · Explain WhyJan 16 2017, 9:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Planguages/clang/codegen/clangrefactoring.h (7 lines)
Copied to languages/clang/tests/test_refactoring.h
Mlanguages/clang/codegen/clangrefactoring.cpp (55 lines)
Mlanguages/clang/tests/CMakeLists.txt (8 lines)
Planguages/clang/tests/test_refactoring.h (39 lines)
Copied from languages/clang/codegen/clangrefactoring.h
AMlanguages/clang/tests/test_refactoring.cpp (143 lines)

Diff 10209

View Options

languages/clang/codegen/clangrefactoring.h

Loading...
View Options

languages/clang/codegen/clangrefactoring.cpp

Loading...
View Options

languages/clang/tests/CMakeLists.txt

Loading...
View Options

languages/clang/tests/test_refactoring.h

Loading...
View Options

languages/clang/tests/test_refactoring.cpp

Loading...