Differential D4088

Don't pass immutable properties from updateAction
ClosedPublic
Actions

Authored by davidedmundson on Jan 11 2017, 6:44 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:6042e8feb94d: Don't pass immutable properties from updateAction
R120:6042e8feb94d: Don't pass immutable properties from updateAction
Summary

See comment at the top of createAction
Reduces the number of warnings in updateAction about unhandled
properties

Test Plan

Still works

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10064.Jan 11 2017, 6:44 PM
davidedmundson retitled this revision from to Don't pass immutable properties from updateAction.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 11 2017, 6:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Jan 11 2017, 6:49 PM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Jan 11 2017, 6:49 PM
Closed by commit R120:6042e8feb94d: Don't pass immutable properties from updateAction (authored by davidedmundson). · Explain WhyJan 11 2017, 7:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibdbusmenuqt/dbusmenuimporter.cpp (7 lines)

Diff 10066

View Options

libdbusmenuqt/dbusmenuimporter.cpp

Loading...