panel alignment/visibility not resolution dependent
ClosedPublic

Authored by mart on Jan 11 2017, 6:25 PM.

Details

Summary

panel size and position in pixel is dependent from screen resolution,
this saved in different config groups, as it should.
but two properies of panelview shouldn't change between resolution,
that are visibility and alignment, otherwise the panel changes
behavior in an unpredictable way when resolution changes.

BUG:372064

Test Plan

started plasmashell with old config, values have been correctly
migrated to the parent group that's common for all resolutions

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 10063.Jan 11 2017, 6:25 PM
mart retitled this revision from to panel alignment/visibility not resolution dependent.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 11 2017, 6:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

If you want to do this without casting another approach is to load the legacy version as the default
config().parent().readEntry<int>("panelVisibility", config.readEntry(, NormalPanel));

davidedmundson accepted this revision.Jan 11 2017, 7:09 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 11 2017, 7:09 PM
mart updated this revision to Diff 10070.Jan 11 2017, 7:46 PM
mart edited edge metadata.
  • avoid storing in temporaries
This revision was automatically updated to reflect the committed changes.