Differential D4086

If we changed containment with the config open, relaunch the config dialog
ClosedPublic
Actions

Authored by davidedmundson on Jan 11 2017, 6:08 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:8e086d25b57a: If we changed containment with the config open, relaunch the config dialog
R871:8e086d25b57a: If we changed containment with the config open, relaunch the config dialog
Summary

If we changed containment with the config open, relaunch the config
dialog but for the new containment.

This provides a somewhat seamless changing desktop types.

BUG: 355642

Test Plan

Opened config, changed type, hit apply -> dialog was replaced
Opened config, changed activity -> Dialog was replaced
Opened config, Closed Config, changed activity -> Nothing happened

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10060.Jan 11 2017, 6:08 PM
davidedmundson retitled this revision from to If we changed containment with the config open, relaunch the config dialog.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 11 2017, 6:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson updated this revision to Diff 10062.Jan 11 2017, 6:09 PM

Ninja fix. Only when we're actually configuring the desktop though

mart added a subscriber: mart.Jan 11 2017, 6:30 PM
mart added inline comments.
shell/desktopview.cpp
267

this should be disconnected somewhere..
wouldn't this always show the config dialog after the first time, regardless the config dialog is open or not? (ie, activity switch)

davidedmundson added inline comments.Jan 11 2017, 7:05 PM
shell/desktopview.cpp
267

The third argument is the dialog so that we automatically disconnect when the dialog is deleted (stops showing)

mart accepted this revision.Jan 11 2017, 7:45 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 11 2017, 7:45 PM
Closed by commit R120:8e086d25b57a: If we changed containment with the config open, relaunch the config dialog (authored by davidedmundson). · Explain WhyJan 11 2017, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/desktopview.cpp (5 lines)

Diff 10072

View Options

shell/desktopview.cpp

Loading...