Differential D4036

When updating another user's avatar don't save icon into our home
ClosedPublic
Actions

Authored by davidedmundson on Jan 9 2017, 2:35 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R128:0d43e0379a16: When updating another user's avatar don't save icon into our home
Summary

We want to save the face using AccountsService, but for backwards
compatibility we also save the icon into ~/.face for old
apps/DisplayManagers that still expect that.

This works when setting a face as the current user, but doesn't make
sense when setting the icon of another user.

We can't fix it to write into another user's home, so instead of trying
just skip that step and only update AccountsService.

BUG: 365662
BUG: 360005
BUG: 371663

Test Plan

Changed my user's avatar. AccountsService updated ~/.face updated

Changed another user's avatar from my account. Accounts service updated, ~/.face was
unchanged

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 9888.Jan 9 2017, 2:35 AM
davidedmundson retitled this revision from to When updating another user's avatar don't save icon into our home.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 9 2017, 2:35 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 10 2017, 3:33 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 10 2017, 3:33 PM
Closed by commit R128:0d43e0379a16: When updating another user's avatar don't save icon into our home (authored by davidedmundson). · Explain WhyJan 13 2017, 3:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/accountinfo.cpp (39 lines)

Diff 10145

View Options

src/accountinfo.cpp

Loading...