Remove shell's copy of PlasmaQuick headers
ClosedPublic
Actions

Authored by davidedmundson on Jan 8 2017, 11:15 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

It's exported and we're including the include path in our cmake so we
had two paths to the same thing included.

Test Plan

Compiled

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson retitled this revision from to Remove shell's copy of PlasmaQuick headers.

davidedmundson updated this object.

davidedmundson edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

fixup phab

remove irrelevant bit of diff meant for another commit

markg requested changes to this revision.Jan 8 2017, 11:20 PM

markg added a reviewer: markg.

markg added a subscriber: markg.

markg added inline comments.

shell/containmentconfigview.h
56 ↗	(On Diff #9882)	I think you forgot to remove this one? ;) For this commit that is.

This revision now requires changes to proceed.Jan 8 2017, 11:20 PM

Ahh, now it's gone.

You're doing things in little pieces? hehe.
Ship it.

This revision is now accepted and ready to land.Jan 8 2017, 11:22 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		shell/desktopview.h (4 lines)
M		shell/panelconfigview.h (5 lines)
M		shell/panelview.h (4 lines)
D	M	shell/plasmaquick/configmodel.h (126 lines)
D	M	shell/plasmaquick/configview.h (92 lines)
D	M	shell/plasmaquick/containmentview.h (135 lines)
M		shell/shellcorona.cpp (1 line)
M		shell/standaloneappcorona.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	9880	55fae87		Jan 8 2017, 11:15 PM	★	★
Diff 2	9882	55fae87	fixup phab	Jan 8 2017, 11:17 PM	★	★
Diff 3	9883	55fae87	remove irrelevant bit of diff meant for another commit	Jan 8 2017, 11:19 PM	★	★
Diff 4	9912	8f74e49	R120:04c54f4e582808acf235f60f7764a1e3639046e7	Jan 9 2017, 1:50 PM	★	★