Fixes to ACBF reading

Authored by jessep on Jan 5 2017, 6:11 PM.


Group Reviewers
R157:60e3d900beda: Fixes to ACBF reading
  • Cleaned the code a bit.
  • Fixed potential issues with some documents.
  • Fixed characters element name.
Test Plan

Can read Pepper & Carrot 1 & 2 and some other acbf comics from

Diff Detail

R157 Peruse
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
jessep updated this revision to Diff 9776.Jan 5 2017, 6:11 PM
jessep retitled this revision from to Fixes to ACBF reading.
jessep updated this object.
jessep edited the test plan for this revision. (Show Details)
leinir accepted this revision.Jan 5 2017, 6:59 PM
leinir added a reviewer: leinir.
leinir added a subscriber: leinir.

This does change the logic somewhat... But as the result is simpler, that's fine with me :)


You know, i felt certain that i had read "character" in the specification... Turns out that i hadn't :)

This revision is now accepted and ready to land.Jan 5 2017, 6:59 PM
jessep added a comment.Jan 5 2017, 9:03 PM

Could you land it, I don't have access

If you would like to get access, we can set you up with that - would make life easier in the future :)

Yeah. Commit access would be useful, but is 1 patch enough to get it?

Given the quality here, sure - the process is described here, and when it comes to the whole reference thing, point to me :)

This revision was automatically updated to reflect the committed changes.