Fixes to ACBF reading
ClosedPublic
Actions

Authored by jessep on Jan 5 2017, 6:11 PM.

Details

Reviewers

leinir

Group Reviewers

Peruse

Commits

R157:60e3d900beda: Fixes to ACBF reading

Summary

Test Plan

Can read Pepper & Carrot 1 & 2 and some other acbf comics from fictionbook-lib.org.

Repository

R157 Peruse

Branch

acbf-reader-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

jessep retitled this revision from to Fixes to ACBF reading.

jessep updated this object.

jessep edited the test plan for this revision. (Show Details)

This does change the logic somewhat... But as the result is simpler, that's fine with me :)

src/acbf/AcbfBookinfo.cpp
174	You know, i felt certain that i had read "character" in the specification... Turns out that i hadn't :)

This revision is now accepted and ready to land.Jan 5 2017, 6:59 PM

Could you land it, I don't have access

If you would like to get access, we can set you up with that - would make life easier in the future :)

Yeah. Commit access would be useful, but is 1 patch enough to get it?

Given the quality here, sure - the process is described here, and when it comes to the whole reference thing, point to me :) https://community.kde.org/Infrastructure/Get_a_Developer_Account

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/acbf/AcbfAuthor.cpp (11 lines)
M			src/acbf/AcbfBody.cpp (13 lines)
M			src/acbf/AcbfBookinfo.cpp (32 lines)
M			src/acbf/AcbfDocument.cpp (12 lines)
M			src/acbf/AcbfDocumentinfo.cpp (27 lines)
M			src/acbf/AcbfLanguage.cpp (1 line)
M			src/acbf/AcbfMetadata.cpp (13 lines)
M			src/acbf/AcbfPage.cpp (14 lines)
M			src/acbf/AcbfPublishinfo.cpp (15 lines)
M			src/acbf/AcbfTextarea.cpp (13 lines)
M			src/acbf/AcbfTextlayer.cpp (13 lines)