Differential D3969

Kill audioplayercontrolrunner
ClosedPublic
Actions

Authored by broulik on Jan 4 2017, 6:27 PM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

R114:4f464465489b: Kill audioplayercontrolrunner

Summary

This is yet another mpris implementation and nowadays we have the media controller applet (which is actually maintained compared to this) as well as MPRIS-driven global shortcuts.

Test Plan

I've never seen this thing actually work. It seems to rely heavily on a configuration interface for keywords that you cannot even access anymore in krunner5

Diff Detail

Repository

R114 Plasma Addons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik updated this revision to Diff 9724.Jan 4 2017, 6:27 PM

broulik retitled this revision from to Kill audioplayercontrolrunner.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added a reviewer: Plasma.

broulik set the repository for this revision to R114 Plasma Addons.

Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2017, 6:27 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

:''(

ooh, well, so long

This revision is now accepted and ready to land.Jan 5 2017, 11:24 AM

Closed by commit R114:4f464465489b: Kill audioplayercontrolrunner (authored by broulik). · Explain WhyJan 11 2017, 9:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		runners/CMakeLists.txt (1 line)
D	M	runners/audioplayercontrol/CMakeLists.txt (34 lines)
D	M	runners/audioplayercontrol/Messages.sh (3 lines)
D	M	runners/audioplayercontrol/TODO (3 lines)
D	M	runners/audioplayercontrol/audioplayercontrolconfigkeys.h (40 lines)
D	M	runners/audioplayercontrol/audioplayercontrolrunner.h (167 lines)
D	M	runners/audioplayercontrol/audioplayercontrolrunner.cpp (548 lines)
D	M	runners/audioplayercontrol/audioplayercontrolrunner_config.h (56 lines)
D	M	runners/audioplayercontrol/audioplayercontrolrunner_config.cpp (194 lines)
D	M	runners/audioplayercontrol/audioplayercontrolrunner_config.ui (570 lines)
D	M	runners/audioplayercontrol/imageiconengine.h (42 lines)
D	M	runners/audioplayercontrol/imageiconengine.cpp (64 lines)
D	M	runners/audioplayercontrol/plasma-runner-audioplayercontrol.desktop (106 lines)
D	M	runners/audioplayercontrol/plasma-runner-audioplayercontrol_config.desktop (58 lines)