[Fifteen Puzzle] Add "Browse" button
ClosedPublic

Authored by broulik on Jan 4 2017, 6:18 PM.

Details

Summary

There's a text field for entering a path to an image to use as puzzle. Add a Browse button to make it actually useful.
We'll strip the file:// prefix as the image handler cannot cope with remote images anyway.

Test Plan

The text field isn't disabled when the checkbox is unchecked, instead, it's smarter: as soon as you start typing in the text field or click the browse button, it's automatically checked. Saves you a enable checkbox and then press browse dance. (We should use this approach more imho)

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9722.Jan 4 2017, 6:18 PM
broulik retitled this revision from to [Fifteen Puzzle] Add "Browse" button.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2017, 6:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 5 2017, 11:23 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 5 2017, 11:23 AM
This revision was automatically updated to reflect the committed changes.