Differential D3961

[Fifteen Puzzle] Remove custom color picker
ClosedPublic
Actions

Authored by broulik on Jan 4 2017, 3:25 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R114:fb6a95332a3c: [Fifteen Puzzle] Remove custom color picker
Summary

The round color picker looked fancy but for the sake of consistency and code quantity just use the standard component we have for this.

Test Plan

The config dialog reflects the current values when it opens and changing background and foreground colors works.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9711.Jan 4 2017, 3:25 PM
broulik retitled this revision from to [Fifteen Puzzle] Remove custom color picker.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R114 Plasma Addons.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 4 2017, 3:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jan 4 2017, 3:32 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 4 2017, 3:32 PM
Closed by commit R114:fb6a95332a3c: [Fifteen Puzzle] Remove custom color picker (authored by broulik). · Explain WhyJan 4 2017, 3:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9714

View Options

applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml

Loading...
View Options

applets/fifteenPuzzle/package/contents/ui/configAppearance.qml

Loading...