Move SNI's libdbusmenu-qt fork to the root directory and use that for appmenu too
ClosedPublic

Authored by davidedmundson on Jan 3 2017, 2:06 AM.

Details

Summary

libdbusmenu-qt had an awful bug in it that meant it would spawn a nested
event loop when updating a menu.

In order to fix StatusNotifierItem I ended up making a fork of the 3
small classes that we needed and applying a fix, whilst we waited for
upstream.

We also were including a complicated library+plugin that handled import
and exporting, just to do importing which is rather pointless.

When appmenu support was restored, we ended up re-linking the original
dbusmenu-qt library. The original still had the same bug, manifesting in
a whole new way of Kate's bookmarks menu automatically closing when you
click on it.

This patch shares the same libdbusmenu-qt lib we have for the SNI
dataengine with the one for appmenu.

Test Plan

Everything compiles after removing the find package for old libdbusmenu-qt
Menu in the Plasma applet works a lot better, and doesn't have the bug of menus randomly closing.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Move SNI's libdbusmenu-qt fork to the root directory and use that for appmenu too.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 3 2017, 2:06 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

remove debug that arc decided I had accidentally left out of my commit so added back

broulik accepted this revision.Jan 3 2017, 9:11 AM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Jan 3 2017, 9:11 AM
This revision was automatically updated to reflect the committed changes.