Differential D3908

[Look and feel KCM] Notify PaletteChange on DBus
AbandonedPublic
Actions

Authored by broulik on Jan 1 2017, 4:12 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

Code taken from Colors KCM.

BUG: 373328
FIXED-IN: 5.8.6

Test Plan

When I switch look and feel packages context menus in Plasma instantly reflect the new color choice

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 9584.Jan 1 2017, 4:12 PM
broulik retitled this revision from to [Look and feel KCM] Notify PaletteChange on DBus.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 1 2017, 4:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a comment.Jan 1 2017, 4:15 PM

Hmm, still able to reproduce the bug at times :/ No idea why it only affects plasmashell context menus, though. Other apps like Dolphin pick up the color right away.

davidedmundson requested changes to this revision.Jan 1 2017, 7:23 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

Check the "setColors" method you call on line 299

It ends with: KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);

which is what this does.

This revision now requires changes to proceed.Jan 1 2017, 7:23 PM
broulik abandoned this revision.Jan 3 2017, 11:01 AM

Revision Contents
Changeset List

PathPackages
Mkcms/lookandfeel/kcm.cpp (9 lines)

Diff 9584

View Options

kcms/lookandfeel/kcm.cpp

Loading...