Differential D3906

[Icon Applet] Fully re-populate when user changes Link URL
ClosedPublic
Actions

Authored by broulik on Jan 1 2017, 3:58 PM.

Details

Reviewers
dfaure
Group Reviewers
Plasma
Commits
R871:53c4f98a3391: [Icon Applet] Fully re-populate when user changes Link URL
R120:53c4f98a3391: [Icon Applet] Fully re-populate when user changes Link URL
Summary

When applying KPropertiesDialog of a Link desktop file, the URL might have changed. In this case nuke the local file and start afresh.

Test Plan

Created an icon applet pointing to a file, now changed the Link to the file, it updated its icon, name, open with actions, etc etc. as if I had placed a new icon applet.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 9582.Jan 1 2017, 3:58 PM
broulik retitled this revision from to [Icon Applet] Fully re-populate when user changes Link URL.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, dfaure.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 1 2017, 3:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dfaure accepted this revision.Jan 2 2017, 9:21 AM
dfaure edited edge metadata.
dfaure added inline comments.
applets/icon/iconapplet.cpp
369

It looks like you're reading from a deleted file here ;) But that's not a problem, it works since KDesktopFile (KConfig) caches everything in memory. So it's fine, don't change it, it's just funny to read.

This revision is now accepted and ready to land.Jan 2 2017, 9:21 AM
Closed by commit R120:53c4f98a3391: [Icon Applet] Fully re-populate when user changes Link URL (authored by broulik). · Explain WhyJan 3 2017, 8:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/icon/iconapplet.cpp (9 lines)

Diff 9636

View Options

applets/icon/iconapplet.cpp

Loading...