Differential D3900

Set mute when changing volume to 0 with slider
ClosedPublic
Actions

Authored by drosca on Jan 1 2017, 11:04 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R994:db9f523a03c2: Set mute when changing volume to 0 with slider
R115:db9f523a03c2: Set mute when changing volume to 0 with slider

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 9574.Jan 1 2017, 11:04 AM
drosca retitled this revision from to Set mute when changing volume to 0 with slider.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 1 2017, 11:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
drosca added a comment.Jan 1 2017, 7:33 PM

That's what changing volume with hotkeys is already doing.
Also, we show mute icon when volume is 0, so we should also actually mute it.
And at last, some hw have leds indicating mute, so this makes it light up when moving the slider to zero.

davidedmundson accepted this revision.Jan 1 2017, 7:34 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jan 1 2017, 7:34 PM
Closed by commit R115:db9f523a03c2: Set mute when changing volume to 0 with slider (authored by drosca). · Explain WhyJan 1 2017, 8:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9592

View Options

applet/contents/ui/ListItemBase.qml

Loading...
View Options

src/kcm/package/contents/ui/VolumeSlider.qml

Loading...